commit | eb8eeec259beaf96c0c482355bcbb0a79e02577b | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Wed May 12 13:31:19 2021 +0000 |
committer | Edwin Kempin <ekempin@google.com> | Wed May 12 13:57:55 2021 +0000 |
tree | 74f862811dcc8c347cd59052bd184fcfb031bdb4 | |
parent | ba566c3690926db770fc0b1161b2d72bb524d256 [diff] |
Check for inbound emails that the change is visible Via inbound emails users could post comments on changes that were not visible to them (changes of projects to which they have no read access, non-visible private changes). The user posting the comment didn't get added as a reviewer though. This means that this hole couldn't be used to gain access to private changes. A visibility check wasn't done so far since we used an InternalQuery which has enforceVisibility = false by default. With this change the error message if a change/project doesn't exist or is not visible is always the same so that users cannot probe the existence of a project or change. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I98e1af7d0386fd7b29162fd76ef99270d7e0defc
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.