| commit | e567867555daf0b2b20de89852e58b65604bd46a | [log] [tgz] |
|---|---|---|
| author | Alice Kober-Sotzek <aliceks@google.com> | Thu Sep 10 12:59:52 2020 +0200 |
| committer | Alice Kober-Sotzek <aliceks@google.com> | Wed Sep 16 11:11:34 2020 +0200 |
| tree | c5a317846841df1982f68761c308e47aba41e627 | |
| parent | d4fadd73f1f18514faae7f15db6defc321f7ddaa [diff] |
Extract and rewrite the logic for comment threads We need the logic for comment threads in more places (see I9d8091c3a and I4af5946ce). Instead of duplicating it and possibly getting it wrong, we now consolidate it in one place. This also includes the logic when a comment thread is considered as unresolved/resolved. A large benefit of this extraction is that we finally have proper test coverage for various situations around comment threads. The previous integration tests only verified a common case. The new logic should also cover the issues previously solved by I97c6aeb47 and I2788fdb22. In addition, the new logic also properly covers longer child branches for which comments are not left one after the other but with mixed dates. For just determining the unresolved state of the whole thread, this didn't matter as only the last comment (previously also determined by date for child branches) is relevant. Now that we build the full comment threads and hand them out, we should get the order of the contained comments right. Unfortunately, the frontend orders comments on its own into threads. That logic (currently contained in gr-comment-api.js) might differ from the one implemented in the backend. Improving this situation or aligning the logic is beyond the scope of this change, though. Change-Id: Ie2713ebdbe05b69a705d2c9c03375b206a248e01
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.