tree 6e17ba1bb73710500a6090a1754ed5ac1739757a
parent 4a628ac463027d1d475b7395edac7edf24de7990
author Edwin Kempin <ekempin@google.com> 1664455763 +0200
committer Edwin Kempin <ekempin@google.com> 1664529735 +0200

Revert: Do not check the account visibility of reviewers/CCs

If a change is reverted, Gerrit automatically adds the change owner and
the reviewers of the reverted change as reviewers on the revert change.
CCs of the reverted change are automatically added as CCs on the revert
change.

So far revert failed if any of the accounts that are added as
reviewers/CCs on the revert change are not visible to the caller.
Failing in this case is unnecessary since the user doing the revert
already knows about the existence of the reviewer/CC accounts (see
below) and hence we can just skip the account visibility check for them
during revert.

Reverting a change is only possible if the calling user can see the
change that is being reverted. If a user can see the change, they can
also see the change owner and all its reviewers/CCs regardless of
whether these accounts are visible. This means the user doing the revert
knows that Gerrit accounts exists for all users the are either change
owners, reviewer or CC on the reverted change. This means we can
preserve them as reviewers/CCs on the reverted change, even if their
accounts are not visible to the user doing the revert (as it doesn't
expose the existence of accounts that the user didn't already know
before).

Signed-off-by: Edwin Kempin <ekempin@google.com>
Release-Notes: skip
Change-Id: I8264d96f7cb683c9becefd43d7cc84067d5f2409
Bug: Google b/249230938