tree e6bb3f2612572b070924dbaf267ff7a7420db808
parent 20d6835f4a17e01cdf65de71fe701ffdb85fd6e0
author Youssef Elghareeb <ghareeb@google.com> 1631284661 +0200
committer Youssef Elghareeb <ghareeb@google.com> 1631620041 +0200

Ignore the Rule-Name key in submit record footers

In I3f08f189, we made a change that added a new field to submit records:
the rule name that created the record. That change:
1) Stored the rule name with an extra footer in NoteDb (ChangeUpdate).
2) Updated the read path to parse this footer (ChangeNotesParser).

I3f08f189 was not forward compatible, i.e. old code cannot read and
parse the new footer once it's written and will fail with a parse
exception. A problematic scenario may occur if a Gerrit installation
decided to upgrade to 3.5, then later on downgrade to 3.4.

Instead of cherry-picking I3f08f189 to 3.4 (we don't want 3.4 to write
these new footers), I'm updating the implementation of ChangeNotesParser
to be forward compatible w.r.t. the added field; We can just ignore this
field if we see it.

Change-Id: I2a313798ff72ef3c8beb9978de6d9856f6f6eabf