tree fb908aa15985a019c7450d6c0ec5ccd514b4aa02
parent 30b81bc22170658b19d7d8ffba8c2d64fc396eaf
author Kamil Musin <kamilm@google.com> 1683111207 +0200
committer Kamil Musin <kamilm@google.com> 1683115240 +0200

Minor improvements to non-personal dashboards

- "Waiting" column is calculated in respect to the user whose dashboard
  is shown
- Improving comments in the code
- Sorting of "Your Turn" is similarly done in respect to the user whose
  dashboard is shown.

There are 2 related to each other issues which are unaddressed:
- Ideally we would want dashboardUser to have a proper type instead of
  string. However the value comes from the Url and can be both Id
  (integer), Email (string) and 'self'
- The attention set map used for the sorting and waiting calculation is
  keyed by AccountId so when dashboardUser is Email than we would need
  to first do a lookup for an Id before we render the column

The Email usecase is rare (only happens if email is manually written in
the url), so we will leave both for the future fix.

Google-Bug-Id: b/280562435
Release-Notes: skip
Change-Id: I697dfd170db6dbb1e96f23a9429bf050b3b1fd69