tree 7d1cace41ab601671d9403d76e29124900b27121
parent 09a4d8746018cea2342b6d0aa05f885553c3d815
author David Pursehouse <dpursehouse@collab.net> 1560400546 +0900
committer David Pursehouse <dpursehouse@collab.net> 1560857175 +0000

AbstractPushForReview: Add tests for pushing with skip-validation option

The option to skip commit validation was added in change I80ad47852,
with the name `bypass-review`, which was later renamed in I012e1ea42 to
`skip-validation`. In the former change it was noted in a post-submit
review that no tests were included.

Add test coverage for usage of the skip-validation option, i.e. the
following use cases:

1. Commit validator is invoked on a normal push.

2. Commit validator is not invoked when using the skip-validation option.

3. Push is rejected when using the skip-validation option without having
   the necessary permissions granted. The push is rejected before the
   validator is invoked.

Change-Id: Iac2f1a83ad755d1b29b964b3e42d735379965a60