commit d309b5d1d00d9c8d2b2b96898c005d1994a2e0b4
author Bruce Zu <bruce.zu@sonymobile.com> Thu Mar 06 13:02:17 2014 +0800
committer David Pursehouse <david.pursehouse@sonymobile.com> Thu Mar 06 06:59:35 2014 +0000
tree da79cb844e90a192935067a99fda1971156b04f5
parent 88820201e8597d726411a078757f707b981e44c1

Fix: 'Illegal label name'

review command like

 'ssh -p 29418 user@review gerrit review <change>,<patch-set> --label code-review=+1'

fails with:

 fatal: Illegal label name "code-review="

Fixed by using right parse function.

Bug: Issue 2516
Change-Id: Ib95b377786d89bcc33bf0af6ab7e130084547125

gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java

diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java
index bad87de..e30d41b 100644
--- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java
+++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java
@@ -115,7 +115,7 @@
 
   @Option(name = "--label", aliases = "-l", usage = "custom label(s) to assign", metaVar = "LABEL=VALUE")
   void addLabel(final String token) {
-    LabelVote v = LabelVote.parse(token);
+    LabelVote v = LabelVote.parseWithEquals(token);
     LabelType.checkName(v.getLabel()); // Disallow SUBM.
     customLabels.put(v.getLabel(), v.getValue());
   }