tree 7343ba5caed6517c4c89126f15e2888b7bef13c5
parent cc4c6c1b9b97e0d44f43e1f5de3093adb54694d0
author Nitzan Gur-Furman <nitzan@google.com> 1673870866 +0000
committer Nitzan Gur-Furman <nitzan@google.com> 1674027684 +0000

Revert "Revert "Add project permission for removing votes/labels.""

This reverts commit 7b91e4e06fd1ff5bdfcebb4561fcee32cf48caf2.

Reason for revert: Re-adding the feature with the needed fixes.

Issues with the original change:

1. The added dependency on ChangeData::notes() while checking for
 permissions broke the query flow.
2. For backward compatibility, removing label should be allowed with
either remove-reviewer or remove-vote permissions.
3. ChangeInfoDiffer.getAddedForMap failed when the old map was null.

Bug: Google b/245706858
Bug: Google b/265447204
Change-Id: I5c74804d1dbb51cf6d97de653e47654acd2bf263
Forward-Compatible: checked
Release-Notes: New project permission for removing votes/labels