tree 4ffbc187f8d3c58c976611d4d59a00cd64b8703c
parent 1e5636aeae38e8886dae52267e271e45854e0f69
author Edwin Kempin <ekempin@google.com> 1530796248 +0200
committer Edwin Kempin <ekempin@google.com> 1530863171 +0200

Permission: Don't hand out the modifyable rules list to callers

It's bad practise to give a private list member to callers and let them
do direct modifications on the list. It's better to keep the list
protected within the class. E.g. this would allow us to implement
constraints on the list.

Ideally we would return an ImmutableList from Permission.getRules() but
we cannot use ImmutableList in classes that are used by the GWT UI.

Change-Id: I32ee5e7055d99e0a7865f7c5deb0bbbd1a09e29f
Signed-off-by: Edwin Kempin <ekempin@google.com>