Remove the feature of auto-reloading from the search results page
When going through search results it can be very annoying to lose
the scroll position, so while on the dashboard there is high value
of having fresh results at any time, on the search results page
we feel the benefit is outweighed by the disadvantages.
Release-Notes: skip
Google-Bug-Id: b/238550966
Change-Id: I7e6bdb237c1fa46183531c55485e23c871bc3082
(cherry picked from commit a1f02b060c137a050e53befc05766340a938326f)
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
index 2360312..e11ac9b 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
@@ -39,7 +39,6 @@
import {fireTitleChange} from '../../../utils/event-util';
import {appContext} from '../../../services/app-context';
import {GerritView} from '../../../services/router/router-model';
-import {RELOAD_DASHBOARD_INTERVAL_MS} from '../../../constants/constants';
const LOOKUP_QUERY_PATTERNS: RegExp[] = [
/^\s*i?[0-9a-f]{7,40}\s*$/i, // CHANGE_ID
@@ -113,26 +112,11 @@
private reporting = appContext.reportingService;
- private lastVisibleTimestampMs = 0;
-
constructor() {
super();
this.addEventListener('next-page', () => this._handleNextPage());
this.addEventListener('previous-page', () => this._handlePreviousPage());
this.addEventListener('reload', () => this.reload());
- // We are not currently verifying if the view is actually visible. We rely
- // on gr-app-element to restamp the component if view changes
- document.addEventListener('visibilitychange', () => {
- if (document.visibilityState === 'visible') {
- if (
- Date.now() - this.lastVisibleTimestampMs >
- RELOAD_DASHBOARD_INTERVAL_MS
- )
- this.reload();
- } else {
- this.lastVisibleTimestampMs = Date.now();
- }
- });
}
override connectedCallback() {
