tree 40738ec83c3d14ad9047b1c2757b9e381c3c1679
parent ad955984664803d82c06ce8f1c9323be39572287
author Youssef Elghareeb <ghareeb@google.com> 1634125989 +0200
committer Youssef Elghareeb <ghareeb@google.com> 1634133897 +0200

Submit requirements: merge legacy and non-legacy results

When experiment "enable_legacy_submit_requirements" is enabled, we
convert legacy submit records to submit requirements and return them
with ChangeInfo#submit_requirements.

In order to allow for a smoother migration to new submit requirements,
we can do this in two steps:
1) Add new submit requirements in project.config, track and monitor
their evaluation and make sure they behave correctly.
2) Remove the legacy submit rules (prolog code, label functions).

We would also like to allow creating submit requirements in
project.config with the same name as legacy submit requirements. If this
happens, we don't want the submit requirements API to return results
with duplicate names. In this change, we detect this case and favour
returning the project config's requirement if both results have the same
fulfillment status (i.e. they both allow or disallow change submission).
This change updates both code paths of open changes (in
SubmitRequirmentsEvaluatorImpl) and closed changes (ChangeData).

Change-Id: Id5db11e36aca7824d73cdfaf87f6d8f01dbc761b