tree 728716c895c72117ce3e07b264142818925224d9
parent 576524ce20cd2042c459e1f0410e6990d71d65de
author Patrick Hiesel <hiesel@google.com> 1621935769 +0200
committer Patrick Hiesel <hiesel@google.com> 1622544313 +0000

Implement query parser for approval queries

This commit implements a query parser based on existing logic that runs
predicates over PatchSetApprovals and some related metadata
(ApprovalContext). The intention is that we can replace the existing
boolean configs for copying approvals from one patch set to the next
with simple query strings.

Example:

[label "Foo"]
  copyMaxScore = true
  copyIfTrivialRebase = true

becomes

[label "Foo"]
  copyIf = changekind:trivial-rebase OR is:max

This allows us to be more flexible: The current configs are OR'd
together. Using a query syntax here allows project owners to be
more expressive and allows us to add more predicates in the future
without polluting configs all that much.

A likely candidate for future predicates are group checks on
accounts that gave an approval (e.g. approver-group:Project-Owners).

This commit adds the parser and tests but does not wire it up yet
with project configs. Hence it does not mention anything in Gerrit's
docs yet.

Change-Id: I2d10af61a72197d4dc98b66976257f3b366076e4