commit | 605bc571e8b296398922a4e27f8dd7186d51430d | [log] [tgz] |
---|---|---|
author | Wyatt Allen <wyatta@google.com> | Wed Aug 01 15:08:30 2018 -0700 |
committer | Wyatt Allen <wyatta@google.com> | Wed Aug 01 16:47:01 2018 -0700 |
tree | b24849b1aa4a2b1e56917898feb5ad5c2f0b5e46 | |
parent | 3b5ae7518dcb1c70add3958641387858682171aa [diff] |
Prevent duplicates in change_table preference The change table editor is used to modify what columns appear in change lists with a series of checkboxes. These checkboxes have a click area that is slightly larger than the checkbox itself in order to make them easier to click on. This is accomplished by intercepting a click on the container and relaying it to the checkbox it contains. However, because one event handler was used for three different purposes, every time a user clicked on the checkbox container this would result in two calls to the handler. If the column was being added, this would mean that it would appear in the preference list twice. Duplicating preference names is avoided by splitting the event handlers so that each handler does one thing only. Updates to the preference list are made my querying the state of the checkboxes rather than making incremental updates. The cursor style of the checkbox is updated too. Change-Id: Icb8c4b94209c62c7794112f36e89183776c73ea8
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.