commit | c19c5687fdc27d3e42c705aa6393c416289c911d | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Fri Jul 23 12:10:01 2021 +0200 |
committer | Edwin Kempin <ekempin@google.com> | Mon Jul 26 09:49:02 2021 +0200 |
tree | 8107810ed70adee1aac0267581f731d8ab10131f | |
parent | 1ff1de24c696a99868b3dffea8cf65f768e24b37 [diff] |
RestApiServlet: Handle RequestCancelledException for REST calls Catch RequestCancelledException in RestApiServlet and return proper HTTP response codes. RequestCancelledException is not being thrown yet, this is a preparation to handle it correctly when we start detecting cancelled requests later and aborting them by throwing this exception. If a request is cancelled we return '499 Client Closed Request'. This is a non-standard status code that was introduced by nginx for the case when a client closes the connection [1]. If a request is cancelled due to an exceeded deadline we return '408 Client Provided Deadline Exceeded' or '408 Server Deadline Exceeded'. 408 is a standard response code that is returned when a request timed out [2]. [1] https://httpstatuses.com/499 [2] https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/408 Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ice6d35a04c68e850307fc36d0ef71c5d3a15ecb9
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.