tree 229ece9239e7d9da67c504604bfb04b51587f018
parent 82c6ee9a6db936db07a8964cc3b669de522719fe
author Edwin Kempin <ekempin@google.com> 1751267650 +0000
committer Edwin Kempin <ekempin@google.com> 1751268719 +0000

ChangeQueryBuilder#label: Reject using 'user' and 'group' args together

Using the 'user' and 'group' args together is not supported. Currently
trying to use them together doesn't fail, but silently ignores the
'user' arg, which is bad. This is because both args result in setting
the 'accounts' variable and when we process the 'groups' arg the value
of 'accounts' that has been set for the 'user' arg gets overwritten.

This change may cause disruption to users. For example for projects that
have a submit requirement configured that uses 'submittableIf =
label:Code-Review=MAX,user=non_uploader,group=myGroup' the submit
requirement currently passes if a 'Code-Review=MAX' vote from a user of
the 'myGroup' is present (but the 'user=non_uploader' arg is ignored)
and with this change it will start failing (because the 'user' and
'group' args cannot be used in conjunction).

Release-Notes: Reject using the 'user' and 'group' args together for the 'label' search predicate
Bug: Google b/428579680
Change-Id: I72d088e4aba1f20f71ec13c483085b699f51c890
Signed-off-by: Edwin Kempin <ekempin@google.com>