commit c002ef2b9eb05f29a088cbabb21571ee18b82752
author Dmitrii Filippov <dmfilippov@google.com> Thu Oct 22 08:56:34 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Oct 22 08:56:34 2020 +0000
tree 02a747f12c4279653747da4d6ac2c69ee3b62b17
parent d6ee44b3cd2ff1ecae231160b368ec12e1c9db84
parent 516c59d98abf42cf120f98ce076ab1fc22959494

Merge "Clean up patchset conversion in change view params"

polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts

diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts
index 6491358..bafe32a 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts
@@ -1227,13 +1227,6 @@
       patchNum: value.patchNum,
       basePatchNum: value.basePatchNum || 'PARENT',
     };
-    // TODO(TS): remove once proper type for patchRange is defined
-    if (!isNaN(Number(patchRange.patchNum))) {
-      patchRange.patchNum = Number(patchRange.patchNum) as PatchSetNum;
-    }
-    if (!isNaN(Number(patchRange.basePatchNum))) {
-      patchRange.basePatchNum = Number(patchRange.basePatchNum) as PatchSetNum;
-    }
 
     this.$.fileList.collapseAllDiffs();
     // TODO(TS): change patchRange to PatchRange.