tree daaf63faf72917a6c71980ddec4392371fb2f006
parent a4034715974fdcf2be40cf2145452d1229686d80
author Youssef Elghareeb <ghareeb@google.com> 1638272140 +0100
committer Youssef Elghareeb <ghareeb@google.com> 1638375384 +0100

Copy approvals to the latest PS by matching labels with submit records

Background: we store submit records in NoteDb when the change is merged.
Submit records optionally contain a list of labels and the account ID
that applied the vote, but they do not contain the vote value.

Problem we are solving: approvals from prior patchsets are no longer
copied on demand but approvals are solely read from NoteDb. For old
changes copied approvals are not stored in NoteDb because they were not
backfilled. For merged changes, this means that approvals for labels
that were required for submit and that were satisfied by copied votes
are no longer shown, so we need to backfill them.

In this change, we update reading back approvals from NoteDb for closed
changes: If we find a submit record with an approved label from some
user and we don't find a corresponding approval for it at the latest
patchset, we search for the most recent non-latest patchset that
contains an approval for this label from the user and copy it to the
latest patchset.

Change-Id: I58ea31a5fec033f28cdb9e51f96ea47676816d76