tree a77fb6a5d84266388b18837c5a3a5159419ae2f9
parent 87f4b1d61a04d4f0750d8c82ad06066e5a23422b
author Edwin Kempin <ekempin@google.com> 1477050307 +0200
committer Edwin Kempin <ekempin@google.com> 1477051108 +0200

SubmitRuleEvaluator: Fix NPE when patch set is not set

cannotSubmitDraft() failed with a NullPointerException when patchSet
was null. It was initialising the patch set, but too late and patchSet
was already deferenced once. Since evaluate() is the only caller of
cannotSubmitDraft() and it needs to initialize the patch set before
invoking cannotSubmitDraft() anyway, the call to initialize the patch
set in cannotSubmitDraft() can be removed.

This was e.g. causing 500 Internal Server Error when an anonymous user
was accessing a change with a draft. The request that failed was for
the submitted_together REST endpoint.

Bug: Issue 4796
Change-Id: I1fab717ad985e486409fdf4a5d8845aaefcb40f2
Signed-off-by: Edwin Kempin <ekempin@google.com>