tree 1a8c14969bbdfad46e56c9b3d8ca3d584d0871e6
parent f0f4c50b57f69a6be7a6514dcbe84e88f7026633
author Dave Borowitz <dborowitz@google.com> 1556648213 -0700
committer Dave Borowitz <dborowitz@google.com> 1557326001 -0700

Convert PatchSetApproval to AutoValue

The public API of PatchSetApproval remains the same with respect to
nullability: getTag is a non-nullable Optional, and getRealAccountId
falls back to getAccountId if setRealAccountId was never called. In the
old implementation, these fields were nullable internally, due to
ReviewDb constraints; AutoValue has no such constraints, so they are
plain non-nullable fields. Instead, populating the default values is
done via logic in the builder.

The no-arg defensive copy method is no longer required, since
PatchSetApproval is immutable. copyWithPatchSet is still useful as a
shortcut, because swapping out just the PatchSet.Id nested in the
PatchSetApproval.Key is annoying.

Leave method names the same so that substantive code changes are easier
to review.

Change-Id: I342f87e9a7cd209afa6e4a6d0158a1f3a5d11360