tree 9656b79984a5ba3148b5e7a46e4c58d993de0b72
parent 4e3904cb8ae499dda750cdb78a6da5de4f7e409a
author Edwin Kempin <ekempin@google.com> 1543482587 +0100
committer Edwin Kempin <ekempin@google.com> 1543487308 +0100

Fix IAE when listing reviewers of change that has reviewers by email

Reviewers by email don't have an account ID but formatting reviewers as
JSON tried to get account IDs of all reviewers and trying to get an
account ID from a reviewer by email fails with an
IllegalArgumentException.

Reviewers by email only have an email and optionally a name. Since they
don't have an account we must not invoke the account loader for them. In
addition reviewers by email cannot have approvals so we can skip the
approval format step.

Listing reviewers of a change is not available through the extension API.
This is why the test needs to make a REST call to test this
functionality.

Change-Id: I97226ddce397f2ae9cc3c3526fbc1c4861e4ee58
Signed-off-by: Edwin Kempin <ekempin@google.com>