Fix OperatorPrecedence bug pattern flagged by error prone OperatorPrecedence bug pattern was extended recently to also suggest disambiguation of logical and ternary operators. To avoid confusion, that this could be a false positive, the documentation for this bug patter was adjusted as well: The explicit operator precedence using parens: boolean e = (a || b) ? c : d; should be prefered to implicit operator precedence: boolean e = a || b ? c : d; The intent is that it makes it easier to read, which is of course subjectiver. The Google style guide: [2] suggests adding parens unless "there is no reasonable chance the code will be misinterpreted without them" and adds: "It is not reasonable to assume that every reader has the entire Java operator precedence table memorized." [1] https://github.com/google/error-prone/commit/39d288437add5c0b47f78b00d44c158259b86adf [2] https://google.github.io/styleguide/javaguide.html#s4.7-grouping-parentheses Details: https://errorprone.info/bugpattern/OperatorPrecedence Release-Notes: skip Change-Id: I41fc2f20f19c48bf35fdeaadcc347b3a8390c934
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.