tree 4792430410ebeba6e998344ebf8d58480a893561
parent a32cb2747888301a2591ce28d0bfbdf67aff21a0
author David Pursehouse <dpursehouse@collab.net> 1523889327 +0200
committer David Pursehouse <dpursehouse@collab.net> 1523889711 +0200

Fix internal errors when 'destination:' refers to non-existing destination

When querying with the destination: predicate using a destination name
that does not exist, it is supposed to return an error:

  "Unknown named destination"

However it was not, because of two problems:

- When the revision is null, VersionedAccountDestinations's call to
  getPathInfos results in NPE due to dereferencing the revision.

- When no destinations exist, DestinationList.getDestinations returns
  an empty list, but the ChangeQueryBuilder is only testing for null

Fix both of the bugs and add a test that querying "destination:" with
a non-existing destination results in the correct response.

Adding tests for existing destinations is not within the scope of this
change.

Change-Id: I7787a90a508f61ef19586f327c6be427a0870e69