tree 2a28989b39b74c19f452c823881433e72918605d
parent d363fa34cd0cddb9d2bdd1747a093d9917ce16d4
author David Ostrovsky <david@ostrovsky.org> 1397940767 +0200
committer David Ostrovsky <david@ostrovsky.org> 1398320948 +0200

Acceptance-tests: Fix 'verify: false' bug

Sporadic unit tests failures are caused by long withstanding bug in Jcraft
SSH library.  Despite announcements in the release notes for the versions
0.1.50 and 0.1.51 of this library, claiming that this bug was fixed, that
bug still exists and can be easily reproduced.

This change introduces an unit test, that reliably reproduces the
'verify: false' bug in one test method (that is running against
established SSH port number, so that random port assignments can be
eliminated as the reason for the sporadic unit test failures).

The workaround introduced in this change is to conditionally use
bouncycastle library. Per default bouncycastle library is used. To run unit
tests without it, set NO_BOUNCYCASTLE library to any value:

  NO_BOUNCYCASTLE=1 buck test --all

Change-Id: I9d5fdf992082b3658542d84ed9551ac2bf146414