tree ed314c48d8ca68fa4230f2f1e940fc2bbc68597e
parent 5a92e22f4cdd03331fde1ed9b0ec95a87c88942d
author Changcheng Xiao <xchangcheng@google.com> 1530715497 +0200
committer Changcheng Xiao <xchangcheng@google.com> 1531211057 +0200

Don't use #test(Permission) when #check(permission) is expected

By design, the result of #test(permission) should only considered as a
hint and they might be more permissive than reality. This method should
be used by some cases, e.g. rendering UI, where the unreliable results
are acceptable.

However, there are lots of #test usages which should have been #check.
This is not a problem for DefaultPermissionBackend because both #check
and #test go the same method in the end. But it is a problem for other
permission backend implementations because #test and #check could be
different there.

This CL replaces those #test with #check. It should be a no-op and
should't change existing behaviors.

Change-Id: Ie2cc7adb81ccde4591daff35bacca74f97bc3e25