tree dd4d0ad3123b3dd383ae9d0e6f9e1841283a6291
parent da8a8ef4be0b3ac59ae02db6bd03a485a0792486
author Edwin Kempin <ekempin@google.com> 1543482587 +0100
committer David Pursehouse <dpursehouse@collab.net> 1543490024 +0000

Fix IAE when listing reviewers of change that has reviewers by email

Reviewers by email don't have an account ID but formatting reviewers as
JSON tried to get account IDs of all reviewers and trying to get an
account ID from a reviewer by email fails with an
IllegalArgumentException.

Reviewers by email only have an email and optionally a name. Since they
don't have an account we must not invoke the account loader for them. In
addition reviewers by email cannot have approvals so we can skip the
approval format step.

Listing reviewers of a change is not available through the extension API.
This is why the test needs to make a REST call to test this
functionality.

Change-Id: I97226ddce397f2ae9cc3c3526fbc1c4861e4ee58
Signed-off-by: Edwin Kempin <ekempin@google.com>
(cherry picked from commit b7a24723c121fc159962780b2f1ce0e176fe8e90)