tree 8d26beaf2fb8bb7ebf26cd6f6f394f60ea822245
parent d986f1eb8961b391bcdf85f6a88dc8b3bf999619
author Youssef Elghareeb <ghareeb@google.com> 1638186324 +0100
committer Youssef Elghareeb <ghareeb@google.com> 1638287814 +0100

Skip the diff cache for persisting copied votes: use RevWalk

We currently persist copied votes on upload and then need to consult
with the diff cache whether the list of files has changed (if the vote
should be copied if list of files has not changed). If we do that using
the diff cache, there are some visibility problems since the commit does
not yet exist in the repository, as it's just being created.

To fix it, we add new methods to the diff interface that accept a
RevWalk object. We load the modified files directly instead of looking
them up from the cache. RevWalk has visibility for the newly created
commit consistently.

This bug is not currently reproducible but we create this change as a
measure to fix potential issues that could arise from this bug. One
example from this bug is  Ibc61b3908 which is resolved.

Change-Id: I1dea31cbff3f113083ec30d649d5a56f0ba1fa29