tree 411438061669ca7ae1dfd0a6018c3fa34bf6cb80
parent afb2cd0b0bd1f07a23982d4456e5e668c5617df2
author Youssef Elghareeb <ghareeb@google.com> 1630064097 +0200
committer Youssef Elghareeb <ghareeb@google.com> 1630568867 +0200

SubmitRecord: Add a field with the rule name that created the record

We need this field since we're going to wrap the existing submit records
into submit requirements to be served with other submit requirements
from project.config.

We need this for a couple of reasons:
1) For submit records containing one or more labels, we want to create
submit requirement results per label of the form
`label:$name=$rule_name`. For submit records containing no labels, we
will create one submit requirement result whose name = rule name.

2) We want to identify the submit record created by the default submit
rule. We need to inspect the label function so that we can create a
proper blocking condition accordingly. For example, for a label with a
MAX_WITH_BLOCK function we want to create the blocking condition as
`label:$name=MAX -label:$name=MIN`.

We write the ruleName field in SubmitRequirementsEvaluator after
evaluating each submit rule. Rule name has the form of
'$plugin_name~$ruleClassName' for example 'gerrit~DefaultSubmitRule'. We
also update the storage of submit records in NoteDb to include the
rule name field.

Change-Id: I3f08f189dd154a36a84ebdd7aec6a553ce6a044c