tree 6d3ca96f44b9fdf177a9adbe06a0f60d01695a12
parent 4a4ab7b1a8af3616b85eb6ecbff08725bf1b0a27
author Dave Borowitz <dborowitz@google.com> 1549666904 -0800
committer Edwin Kempin <ekempin@google.com> 1549894302 +0100

Resolve "self" even if inactive

Different systems may implement reactivation of accounts in different
ways. On googlesource.com, for example, accounts are automatically
reactivated on login through the web UI, but there are other codepaths
where reactivation may not happen automatically. Filtering out inactive
users when resolving "self" is therefore a regression: it would return
no results where prior to the AccountResolver rewrite it would have
returned results.

Fix the regression by resolving "self" even when inactive. I'm not
arguing that not auto-reactivating is the best behavior for
googlesource.com, just switching back to the old behavior of
AccountResolver.

The regressed behavior was especially confusing to debug because it
resulted in an exception message saying "Resolving account 'self'
requires login", even though the user was technically logged in.

Change-Id: I5aaf20eeb94ea6de268a96230d14ac85c4eb1863