| commit | 8e0b0a2b9070be6339ed534346813938a8eb85cb | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Tue Apr 26 10:52:51 2016 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Wed Apr 27 17:03:01 2016 -0400 |
| tree | 1c652cf08ac31f179cd2c986e3b9a76d00b8219e | |
| parent | e47cbbd9e61ca94a0f2778752efd2a678857e2bc [diff] |
ChangeNotesParser: Avoid lots of FooterLine allocations The implementation of RevCommit#getFooterLines(String) always calls getFooterLines(), which creates a new list filled with newly-parsed FooterLine objects. This seems wasteful, especially considering in ChangeNotes we call getFooterLines 10 or so times per commit. Add a subclass of RevWalk that caches the result of getFooterLines in a multimap. I don't claim that this is the most efficient implementation possible, but it does give us the abstraction we need to optimize more later. Some tests were failing in a previous iteration of this change when I didn't implement case-insensitive behavior. Normalize ChangeNotesParserTest to use exactly-matching case in labels, except for a single test method that explicitly tests case-folding behavior. Change-Id: I836afa43cde2c1d8df04286664a3c6cc0fac57a9
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.