| commit | 9581041144f59218b94b069ed200944d1543d0e9 | [log] [tgz] |
|---|---|---|
| author | Fabio Ponciroli <ponch78@gmail.com> | Wed Feb 12 16:16:37 2025 +0100 |
| committer | Fabio Ponciroli <ponch78@gmail.com> | Wed Feb 12 12:14:03 2025 -0800 |
| tree | 5c076abd8397dce36272b12899c688ccd2f26790 | |
| parent | e99704d35c61e078329c7a655f11044ed2014d0b [diff] |
Lookup by change number in ChangeFinder::find
According to the documentation [1] a change number can be used as
{change-id} if "it uniquely identifies one change".
In case of imported changes this is not working since
`ChangeFinder::find` looks up by legacy change ID. Legacy change ID is
used as the document id in Lucene, which in case of imported changes
doesn't correspond to the change number. The correct way of searching
for a change is via the `change` field.
The use of legacy change ID was breaking REST-API calls like:
* changes/%s/revisions/%s/related
* changes/%s/revisions/%s/files
and potentially many other REST-API based on the ChangesCollection to
discover the change by its number.
NOTE: This change impacts only the direct REST-API calls from scripting
as the UI always uses the format <project-name>~<change-num>.
[1]:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-id
Bug: Issue 396060185
Release-Notes: Lookup by change number in ChangeFinder::find
Change-Id: I6c57ea2a6caa9e33152955746c9c4d3d446a4d73
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.