)]}'
{
  "commit": "91d8fe01f95b6c583a595896cc73260d6d359f16",
  "tree": "57475e1f6150ca25d6e26c262c221d746e5712ee",
  "parents": [
    "938398f9dc7bf332034582a4014f2de48f5f028f"
  ],
  "author": {
    "name": "Dave Borowitz",
    "email": "dborowitz@google.com",
    "time": "Tue Jul 11 13:29:14 2017 -0400"
  },
  "committer": {
    "name": "David Pursehouse",
    "email": "dpursehouse@collab.net",
    "time": "Wed Sep 19 10:46:50 2018 +0900"
  },
  "message": "AbstractDaemonTest: Don\u0027t delete common server path too early\n\nChaining the TemporaryFolder with the custom TestRule results in the\ndirectory for the common server being deleted after the first test\nmethod, even though it might still be needed. This means a @UseLocalDisk\nclass cannot have more than one method, or things break, including but\nnot limited to the NRT reopen threads throwing exceptions due to the\nindex files disappearing out from under them. We just got lucky that\nnone of our local disk tests were actually affected by this.\n\nTo make this work, we can\u0027t tie the lifetime of the TemporaryFolder to a\nsingle AbstractDaemonTest method invocation. Instead, create the tempdir\nwithin GerritServer#initAndStart, and allow callers to get it back out.\nWe have to be a bit more careful about managing the lifetime of the\ntempdir since some GerritServers, particularly in StandaloneSiteTest,\nhave a shorter lifetime than their tempdirs. Fortunately, TempFileUtil\nmake this relatively easy.\n\nAs a nice side effect, we can get rid of the hack of passing the tempdir\nin via a Gerrit config option.\n\nChange-Id: I80ac66a27bc990f2cef966c9b372c86ce277c471\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ba0b70c355b0ec307a64f63ab86b0ffc13b6cda6",
      "old_mode": 33188,
      "old_path": "gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/AbstractDaemonTest.java",
      "new_id": "88689872e226531b34f9dec03b220c101be4349b",
      "new_mode": 33188,
      "new_path": "gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/AbstractDaemonTest.java"
    },
    {
      "type": "modify",
      "old_id": "bb3cab86fafa317eb20904376d7c0d0521cc344b",
      "old_mode": 33188,
      "old_path": "gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/GerritServer.java",
      "new_id": "5312c73cb4e07315fbef963f0ff8de1f54a4b07d",
      "new_mode": 33188,
      "new_path": "gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/GerritServer.java"
    },
    {
      "type": "modify",
      "old_id": "1096b03758cb91c75cd826f2d94d0e3887fd6be7",
      "old_mode": 33188,
      "old_path": "gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/InMemoryTestingDatabaseModule.java",
      "new_id": "551c26bb11428f4810e7d0781ddea66accb039ec",
      "new_mode": 33188,
      "new_path": "gerrit-acceptance-framework/src/test/java/com/google/gerrit/acceptance/InMemoryTestingDatabaseModule.java"
    },
    {
      "type": "modify",
      "old_id": "64849a42f9e1dd6813037326705dfac3a5a39405",
      "old_mode": 33188,
      "old_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/config/ServerInfoIT.java",
      "new_id": "55ca71914ef75eec143bbf0b9cbd1fd94481bc0f",
      "new_mode": 33188,
      "new_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/config/ServerInfoIT.java"
    },
    {
      "type": "modify",
      "old_id": "eb50b4784a91009017d58f5ddec3c2548ffb2368",
      "old_mode": 33188,
      "old_path": "gerrit-server/src/test/java/com/google/gerrit/testutil/TempFileUtil.java",
      "new_id": "f90a4fe4b0e3ae4b729c36302e35301b4084c3d1",
      "new_mode": 33188,
      "new_path": "gerrit-server/src/test/java/com/google/gerrit/testutil/TempFileUtil.java"
    }
  ]
}