tree eb51ef64a4ce26c3018aafca47f326bb951d9132
parent a00f42a52fad7fc4563630ca925705cecd07429c
author Dave Borowitz <dborowitz@google.com> 1486068590 -0500
committer Dave Borowitz <dborowitz@google.com> 1486482192 -0500

Assign unused Future return value to a variable

Error Prone plans to make this pattern into a compile error; this avoids
future breakage.

In some of these cases, it's not obvious that ignoring the return value
is the correct thing to do; the hope is that the construct is ugly
enough to make the author think twice. In many cases though, it's clear
that a locally-created Runnable or Callable already does its own error
handling, so we can leave a comment alongside the ignored return value.

Eventually many of these should be audited again, and we can replace
some of the @SuppressWarnings with Error Prone's @CanIgnoreReturnValue.
That much is left for future cleanup.

Change-Id: Ia989214d85e0d6c387e388a77178e0b5c4bf2498