tree 378a5a9ebf575e9f8c2a0eb19133a2333fdac0c6
parent c54e2049f1ee32abce14dd527388074389e3f594
author Dmitrii Filippov <dmfilippov@google.com> 1634309561 +0200
committer Dmitrii Filippov <dmfilippov@google.com> 1634639265 +0200

Fix for: ConfigSuite calls @BeforeClass, @AfterClass, @ClassRule twice

By default, there is a class/suite -> test hierarchy for runners.
ConfigSuite adds an additional level: class/suite -> config -> test.
This additional level is implemented by ConfigRunner. The ConfigRunner
extends BlockJUnit4ClassRunner and executes @BeforeClass/@AfterClass
and all @ClassRule. But the top level (class/suite) executes the same
(for the same class), so double initialization happens in tests.

This change fix the issue by replacing @BeforeClass, @AfterClass and
@ClassRule with @BeforeConfig, @AfterConfig and @ConfigRule in
ConfigSuite.ConfigRunner.

Additionally, the fix adds SystemPropertiesTestRule which allows safely
set and restore system properties. This change is required, because
due to the original bug, the BeforeClass has been executed twice and
the propertyValueBeforeTest was set to the wrong value after the second
execution.

Change-Id: Ia6f98f9a09344a9fdec5f6cf93fefc69bb5f8209