Do not strip out "-- >8 --" comment in commit-msg hook

When commiting with "git commit --cleanup=scissors" or "git commit
--verbose", Git includes the following lines in the commit message
template, with additional information that should not go in the commit
message after it:

 # ------------------------ >8 ------------------------
 # Do not modify or remove the line above.
 # Everything below it will be ignored.

In I78b50a789860cc11d63d891b0507786890158754 (Handle messages with
only comments in the commit-msg hook, 2018-12-18), we started
stripping comments from the proposed commit message in order to
determine whether it is empty and as an accidental side effect we lost
this line.  As a result, Git includes the supporting information
(e.g., the diff) in the commit message.

Fortunately we only needed to strip out comments in order to check for
emptiness.  Afterward, the hook invokes "git interpret-trailers",
which is prepared to cope with comments and scissor lines in front of
a diff in recent versions of Git[*].  Fix the hook to work in scissors
mode by using the stripped commit message only for the emptiness check
and going back to the unstripped message for subsequent steps.

This way, users can run "git commit -v" without having the diff end up
in the resulting commit message.

Users with older versions of Git will not benefit from this fix, but
it does not produce a regression there, either: "git commit" in
cleanup modes other than scissors continues to work as expected.  In
other words, in all cases this works as well as before I78b50a78986.

[*] v2.13.1~16^2 (interpret-trailers: honor the cut line, 2017-05-15)

Bug: Issue 10346
Change-Id: I633e5db4643851376422f839d969094043abb5c5
(cherry picked from commit 731eb42b8aed36cb9b3b584458479484e77c4f48)
2 files changed
tree: 437bb9ac71f4fbfa3a445824b6fa04c28f50db4d
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. .bazelproject
  21. .bazelrc
  22. .editorconfig
  23. .git-blame-ignore-revs
  24. .gitignore
  25. .gitmodules
  26. .mailmap
  27. .pydevproject
  28. BUILD
  29. COPYING
  30. INSTALL
  31. README.md
  32. SUBMITTING_PATCHES
  33. version.bzl
  34. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.