commit 8bb537d58cb7d7d3b48b7fa079c1c70111e412fe
author Milutin Kristofic <milutin@google.com> Fri Feb 14 15:06:10 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Feb 14 15:06:10 2020 +0000
tree fd3ce4becffeb358df752b0dc6ebb3e152189de3
parent 25edb49b459a0bc9604661b8768892dec732e27a
parent 2785ddfc1a93119f8bd0764c0c63c3367b5efcc4

Merge "Make blame annotation as link"

polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js
index 7a20dbb..8ce5c7a 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder.js
@@ -577,11 +577,9 @@
     const blameNode = this._createElement('span',
         isStartOfRange ? 'startOfRange' : '');
 
-    const shaNode = this._createElement('span', 'blameDate');
+    const shaNode = this._createElement('a', 'blameDate');
     shaNode.innerText = `${date}`;
-    shaNode.onclick = function() {
-      location.href = '/q/' + commit.id;
-    };
+    shaNode.setAttribute('href', `/q/${commit.id}`);
     blameNode.appendChild(shaNode);
 
     const shortName = commit.author.split(' ')[0];

polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html

diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
index 8380984..590537d 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
+++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
@@ -281,7 +281,7 @@
       td.blame .blameDate {
         font-family: var(--monospace-font-family);
         color: var(--link-color);
-        cursor: pointer;
+        text-decoration: none;
       }
       .full-width td.blame {
         overflow: hidden;