Merge "Update README to use navigationToken for stubbing"
diff --git a/polygerrit-ui/README.md b/polygerrit-ui/README.md
index ada788d..8924d67 100644
--- a/polygerrit-ui/README.md
+++ b/polygerrit-ui/README.md
@@ -370,14 +370,16 @@
variable:
```
// Before:
-sinon.stub(GerritNav, 'getUrlForChange')
+const navService = testResolver(navigationToken);
+sinon.stub(navService, 'setUrl');
...
-assert.equal(GerritNav.getUrlForChange.lastCall.args[4], '#message-a12345');
+assert.equal(navService.setUrl.lastCall.firstArg, '/c/123');
// After:
-const getUrlStub = sinon.stub(GerritNav, 'getUrlForChange');
+const navService = testResolver(navigationToken);
+const setUrlStub = sinon.stub(navService, 'setUrl');
...
-assert.equal(getUrlStub.lastCall.args[4], '#message-a12345');
+assert.equal(setUrlStub.lastCall.firstArg, '/c/123');
```
If you need to define a type for such variable, you can use one of the following
@@ -389,7 +391,7 @@
// Non static members, option 2
let updateHeightSpy_prototype: SinonSpyMember<typeof GrChangeView.prototype._updateRelatedChangeMaxHeight>;
// Static members
- let navigateToChangeStub: SinonStubbedMember<typeof GerritNav.navigateToChange>;
+ let setUrlStub: SinonStubbedMember<NavigationService['setUrl']>;
// For interfaces
let getMergeableStub: SinonStubbedMember<RestApiService['getMergeable']>;
});