commit | 287423cbe55a4cf1450a21539ccc411941f5fd91 | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Thu Feb 02 09:07:22 2023 +0100 |
committer | Ben Rohlfs <brohlfs@google.com> | Thu Feb 02 16:14:57 2023 +0100 |
tree | 8f52b5cbc1ad7c92c52508cbf6763900f50d6ced | |
parent | d47f9b75a385467c77e12c938081c1ec7d0f8311 [diff] |
Fix issue with search view not updating During navigation the router was updating `changes` in search view state to `[]`. If at the same time the `query` was unchanged, then the `reloadTrigger` in the search view model would not fire. The root cause here is that `changes` does not at all belong into the view state. But we are reluctant to do a deeper refactoring right now. So instead we are just making sure that the router never updates the `changes`. Tested using Dev Helper with the scenario described in the referenced issue. Release-Notes: skip Bug: Issue 16654 Change-Id: I1a5cbd5cfcb78c7b85523290854555c9321706ff
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.