)]}'
{
  "commit": "78c978e40741fdbd5103449a14a5b60614d6fcff",
  "tree": "0a458783ab05054161abe5767178cc3adbe157e5",
  "parents": [
    "09a35b97254f84624775f15283aa6bffaadcda70"
  ],
  "author": {
    "name": "Scott Dial",
    "email": "geekmug@gmail.com",
    "time": "Sun Aug 11 16:52:51 2013 -0400"
  },
  "committer": {
    "name": "Scott Dial",
    "email": "geekmug@gmail.com",
    "time": "Mon Aug 12 21:00:26 2013 -0400"
  },
  "message": "Expand capabilities of ldap.groupMemberPattern\n\nPreviously, the pattern supported a limited set of variables that were\neither accidentially available (due to their use in other queries) or\nhard-coded (e.g., `username` is a special-case that was added).\nFurthermore, the documentation made reference to being able to use\nvariables such as `${uidNumber}` even though they are not actually\nsupported (since `uidNumber` is normally never queried). Under the\ndefault RFC 2307 configuration of LDAP, the only variables available\nwere `displayName, `mail`, `uid`, and `username` (It\u0027s noteworthy\nthat `username` was added as a special-case due to the default\n`groupMemberPattern` containing `${username}` even though `username`\nis substitued by Gerrit and not LDAP).\n\nThis changeset removes the artificial restrictions on the attributes\nused in the `groupMemberPattern`. Any variable is assumed to\noriginate from the account, but `username` is still overridden and\nprovided by Gerrit (as before). This allows more expressive patterns,\nwhich allows us to fix an outstanding bug in group matching. Prevously,\na user whose `gidNumber` matched the group\u0027s `gidNumber` would not have\nbeen included in the group. This changeset updates the default\n`groupMemberPattern` to account for this issue by adding the additional\ncase of `(gidNumber\u003d${gidNumber}`.\n\nBug: Issue 2054\nChange-Id: Iff3a14c569a10c1ef693b672f4710fb6f2f8d9a6\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6228a94ab726bb50c9f3d747bf906947db052df2",
      "old_mode": 33188,
      "old_path": "Documentation/config-gerrit.txt",
      "new_id": "27a0937f635ecaa83fe70e3d3c62226041e04607",
      "new_mode": 33188,
      "new_path": "Documentation/config-gerrit.txt"
    },
    {
      "type": "modify",
      "old_id": "0151dde40f4360dda04477bebbe885e64287f310",
      "old_mode": 33188,
      "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java",
      "new_id": "7d0ad24325866c8bbbc896932ec89a9d767b127a",
      "new_mode": 33188,
      "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/Helper.java"
    },
    {
      "type": "modify",
      "old_id": "db5baebfc0babc4cda0a63c4d30f096e9e109a0a",
      "old_mode": 33188,
      "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapType.java",
      "new_id": "3c1b0d22b388aeb126dbd5ba4956322ccddbe617",
      "new_mode": 33188,
      "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapType.java"
    }
  ]
}