)]}'
{
  "commit": "77a3ac909e1a67347c928e3e413e5b12b8e3b565",
  "tree": "3587ab45124aaa3988dd779936239d6ed8b42311",
  "parents": [
    "f5c1bf60c10474bcf5cd427a490b16403c0c6c35"
  ],
  "author": {
    "name": "Edwin Kempin",
    "email": "ekempin@google.com",
    "time": "Mon Jul 17 13:49:22 2017 +0200"
  },
  "committer": {
    "name": "Edwin Kempin",
    "email": "ekempin@google.com",
    "time": "Mon Jul 17 15:22:45 2017 +0200"
  },
  "message": "Also return inactive accounts for internal account queries\n\nBy default account queries only returned active accounts since\nAccountIndexRewriter added \"is:active\" to the query if the query didn\u0027t\nhave a predicate for the ACTIVE field yet. This default makes sense for\nuser queries, but for Gerrit internal queries we rather want to find all\nmatching accounts (active and inactive accounts).\n\nE.g. AccountCacheImpl#ByNameLoader uses the InternalAccountQuery to find\naccounts by username and assumes that also inactive accounts would be\nincluded in the result.\n\nTo fix this the logic for adding \"is:active\" to the query is removed\nfrom AccountIndexRewriter. Instead users of AccountQueryProcessor must\nnow add the \"is:active\" predicate to the query if it is desired. We do\nthis for the QueryAccounts REST endpoint, for the reviewer suggestion\nand for the account suggestion in the singleusergroup plugin. This way\nthe behaviour in the UI and in REST API users stays the same. Only the\nbehaviour for internal account queries is changed.\n\nAn alternative fix has been implemented as change I2402da18f7 but review\ndiscussions on that change showed that the solution that is implemented\nin this change is preferred.\n\nChange-Id: I795925f14435088885bb22ab7183e4058bb802fd\nSigned-off-by: Edwin Kempin \u003cekempin@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "86cccda8ac6b6244f6e25ceb19213290869cd90b",
      "old_mode": 33188,
      "old_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/accounts/AccountIT.java",
      "new_id": "d2af78861a4c6774d3e0f3144e5da41758d7d990",
      "new_mode": 33188,
      "new_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/accounts/AccountIT.java"
    },
    {
      "type": "modify",
      "old_id": "b1f75a04f3b7322d9b52388b107a70922d908877",
      "old_mode": 33188,
      "old_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/SuggestReviewersIT.java",
      "new_id": "33ff5a4a6896ae5d4ae508f209caa706cebed2ee",
      "new_mode": 33188,
      "new_path": "gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/SuggestReviewersIT.java"
    },
    {
      "type": "modify",
      "old_id": "d3083e89cbca45cb7dffc35263cf1ece0421059d",
      "old_mode": 33188,
      "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/ReviewersUtil.java",
      "new_id": "57a81c8e0330f5b8b15534d34d2618e008a29ef3",
      "new_mode": 33188,
      "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/ReviewersUtil.java"
    },
    {
      "type": "modify",
      "old_id": "a8e6dc046d1f4626779f13fd1137d0bab82273d2",
      "old_mode": 33188,
      "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/account/QueryAccounts.java",
      "new_id": "f270b3c19ec3f359aadedc733e262baccc974f3e",
      "new_mode": 33188,
      "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/account/QueryAccounts.java"
    },
    {
      "type": "modify",
      "old_id": "4fd7833a79099d551cee64b7401a78ba92d43a35",
      "old_mode": 33188,
      "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/index/account/AccountIndexRewriter.java",
      "new_id": "c6b2b4564763cdf6bc3c343ded786e95d229b566",
      "new_mode": 33188,
      "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/index/account/AccountIndexRewriter.java"
    },
    {
      "type": "modify",
      "old_id": "6c8948f68151bd36be175c8c57ce7783831afd4c",
      "old_mode": 33188,
      "old_path": "gerrit-server/src/main/java/com/google/gerrit/server/query/account/AccountPredicates.java",
      "new_id": "e13bd0f2acfebe3767c99f15824f0dceb753b277",
      "new_mode": 33188,
      "new_path": "gerrit-server/src/main/java/com/google/gerrit/server/query/account/AccountPredicates.java"
    },
    {
      "type": "modify",
      "old_id": "a4c9e7eb2e3165c981f518457e323d1154d6efc4",
      "old_mode": 57344,
      "old_path": "plugins/singleusergroup",
      "new_id": "2937f2a03b63c812b4901d1e0de63f8f8938762d",
      "new_mode": 57344,
      "new_path": "plugins/singleusergroup"
    }
  ]
}