tree 485ecd6977f978c6623f32b349fea56a28dd6b0b
parent 571fc7251a28d40195f9ba8009bf57b280f5b2cb
author Jacek Centkowski <geminica.programs@gmail.com> 1687245547 +0200
committer Jacek Centkowski <geminica.programs@gmail.com> 1687936057 +0200

Modify 'sanitizeMetricName' to avoid collisions

At present there is a simple 'DropWizardMetricMaker.sanitizeMetricName'
implementation that:
* replaces the leading `/` with `_`
* reduces the repeated `/` chars to a single `/`
* removes the ending `/`
* replaces not supported chars with `_`

As a result collision between the sanitized metric names can be easily
created e.g. `foo_bar` will collide with `foo+bar`.

In order to avoid collisions keep the rules about slashes (they are
needed anyway) and:
* replace not supported chars with `_0x[HEX CODE]_` string (code is
  capitalized)
* the replacement prefix `0x` is prepended with another replacement
  prefix

As a result:
`foo_bar` stays `foo_bar`
`foo+bar` becomes `foo_0x2B_bar`
`foo_0x2B_bar` becomes `foo_0x_0x2B_bar`
and collision is no longer possible

The replace algorithm was inspired by the work done in If11e6576eff
(kudos to Dani).

Bug: Issue 40015585
Release-Notes: Enhance metric name sanitize function to remove collision on '_' between metrics. Gerrit core metrics remain unchanged but plugins metrics could be affected.
Change-Id: I6a5366fa0f1fd494006e2234565371d279e8a7f3