tree 8a7c6a5304a0378eae60a36281c681ee1069adee
parent d5ed5884226ca3b6ebabe290f3bc7c88f3cbf533
author Edwin Kempin <ekempin@google.com> 1648043518 +0100
committer Edwin Kempin <ekempin@google.com> 1648044140 +0100

StickyApprovalsIT: Rename common private test methods to test<NAME>

If 2 (or more) tests share the same implementation, except setup, they
usually have the same name, but with a different suffix (e.g.
notStickyWithCopyAllScoresIfListOfFilesDidNotChangeWhenFileIsAdded_withoutCopyCondition
and
notStickyWithCopyAllScoresIfListOfFilesDidNotChangeWhenFileIsAdded_withCopyCondition).
Both methods delegate to the same private method to do the assertions.
Usually this method has the same name as the test methods without the
suffix, but prefixed with 'test' (e.g.
testNotStickyWithCopyAllScoresIfListOfFilesDidNotChangeWhenFileIsAdded).

The test prefix ensures that these methods can be easily distinguished
from the public test methods that represent test cases (e.g. you can
easier recognize that this is the shared test implementation, rather
than another test case).

Rename the common private test methods to follow this name schema.

Also make sure that the test methods and their common private test
method are always defined next to each other.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ib4bce63d17c39b1d1306be8bd1d83fab830a9929
Release-Notes: skip