tree 0c7bddbf070a2ec42f1c08764a5dcd3bfd87aedb
parent d63b9928e8a2defa30ad113ed0466acc653f39a5
author Wyatt Allen <wyatta@google.com> 1516144511 -0800
committer Wyatt Allen <wyatta@google.com> 1516149723 -0800

Show 404 when project lookup fails

Following Ic9c9f0071e, looking up the project of a nonexistent change
would result in a 404 in the getChange REST call. This network failure
would propagate to a visual not-found message automatically and the
router merely needed to stop attempting to redirect when it recognized
the failure.

In I7336ae90d7, the getChange method is updated to use a query because
the former endpoint had been deprecated. However, because the call
became a query, nonexistent changes would yield an empty set rather than
a 404 network error -- consequently, no visual 404 would appear and the
app would appear to hang.

With this change, instead of merely halting when recognizing a project
lookup failure, the router will display a 404.

The new project lookup query is updated to use the change ID operator
query as Ibe82272104 does.

Bug: Issue 8152
Change-Id: I37a816c41485c077d28f051de281225c20ed495b