| commit | 7076c1bd8b839568d4e12a594947a15a86d43379 | [log] [tgz] |
|---|---|---|
| author | Wyatt Allen <wyatta@google.com> | Tue Jan 16 15:15:11 2018 -0800 |
| committer | Wyatt Allen <wyatta@google.com> | Tue Jan 16 16:42:03 2018 -0800 |
| tree | 0c7bddbf070a2ec42f1c08764a5dcd3bfd87aedb | |
| parent | d63b9928e8a2defa30ad113ed0466acc653f39a5 [diff] |
Show 404 when project lookup fails Following Ic9c9f0071e, looking up the project of a nonexistent change would result in a 404 in the getChange REST call. This network failure would propagate to a visual not-found message automatically and the router merely needed to stop attempting to redirect when it recognized the failure. In I7336ae90d7, the getChange method is updated to use a query because the former endpoint had been deprecated. However, because the call became a query, nonexistent changes would yield an empty set rather than a 404 network error -- consequently, no visual 404 would appear and the app would appear to hang. With this change, instead of merely halting when recognizing a project lookup failure, the router will display a 404. The new project lookup query is updated to use the change ID operator query as Ibe82272104 does. Bug: Issue 8152 Change-Id: I37a816c41485c077d28f051de281225c20ed495b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.