tree 296114670648309b75bcd73fb921e8a3be1c926a
parent f4e81cab18442a93341c664ea686c02d7444ecd4
author Dmitrii Filippov <dmfilippov@google.com> 1626775098 +0200
committer Dmitrii Filippov <dmfilippov@google.com> 1626780765 +0200

Avoid Path.toFile() method for creating PluginConfig from GerritConfig

The Path.toFile() methods works only for Path on default filesystem
and fails with other filesystems (like JimFS). Internally in google
we are going to use JimFS for storing sites data and provide config
from a non-file source.

Having Path.toFile() call in the PluginConfigFactory leads to exception
even if config files are not used at all.

This change removes the .toFile() call from the constructor and
the getFromGerritConfig method. We don't need to check if config file
is modifed, because cfgProvider.get() returns either cached config or
a new config if file is modified.

Other usages of .toFile() in the PluginConfigFactory will be removed
in upcoming changes.

Change-Id: I2df784f71daab1b1ff87eb1e4aceaf917990c587