tree e33f45011e926e5b41c48de4150f7654295e7fc3
parent 3acba18b0eaaec3431930ce81f401a7f55ab072f
author Edwin Kempin <ekempin@google.com> 1532010493 +0200
committer Edwin Kempin <ekempin@google.com> 1532011512 +0200

AccessSection: Consistently disallow passing null into the methods

It is inconsistent that

  AccessSection.remove(null)

is a no-op while

  AccessSection.removePermission(null)

fails with an exception.

Make the behavior of all methods in AccessSection consistent when null
is passed in by always failing with a NullPointerException in this case.

This also fixes a weird behavior when calling getPermission(null,
true). This call created a Permission with name null and added it to
the permission list. Now it fails with a NullPointerException.

We did consider making the behavior of the AccessSection methods
consistent by always allowing/ignoring null values (see change
I1aa786c8f4), however this might have obfuscated some cases where null
was accidentally passed in and we would have liked to get to know about
it.

Change-Id: I2b95651b92a96d4cb78228b7648e24218ad947e0
Signed-off-by: Edwin Kempin <ekempin@google.com>