| commit | 6b0b4c58bbd3a6e02b388f33a5245d32b3c3e1cd | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Jul 19 16:28:13 2018 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Jul 19 16:45:12 2018 +0200 |
| tree | e33f45011e926e5b41c48de4150f7654295e7fc3 | |
| parent | 3acba18b0eaaec3431930ce81f401a7f55ab072f [diff] |
AccessSection: Consistently disallow passing null into the methods It is inconsistent that AccessSection.remove(null) is a no-op while AccessSection.removePermission(null) fails with an exception. Make the behavior of all methods in AccessSection consistent when null is passed in by always failing with a NullPointerException in this case. This also fixes a weird behavior when calling getPermission(null, true). This call created a Permission with name null and added it to the permission list. Now it fails with a NullPointerException. We did consider making the behavior of the AccessSection methods consistent by always allowing/ignoring null values (see change I1aa786c8f4), however this might have obfuscated some cases where null was accidentally passed in and we would have liked to get to know about it. Change-Id: I2b95651b92a96d4cb78228b7648e24218ad947e0 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.