tree 651ba2cb1a986fbd2dc19d6543dcfdb8921caf45
parent 024e5aa31d32c11e0fa7c73028e052bd1b9a157b
author Edwin Kempin <ekempin@google.com> 1547650450 +0100
committer Edwin Kempin <ekempin@google.com> 1547650832 +0100

If submit fails due to dependency on non-visible change include calling user into message

Submitting a change can fail if the commit that should be merged depends
on a commit that belongs to change that is not visible to the calling
user. In this case the following message is returned as part of the 409
response for the submit request:

  Change <change-number>: Depends on change that was not submitted.
  Commit <sha1-commit-1> depends on commit <sha1-commit-2> which cannot
  be merged.  Is the change of this commit not visible or was it
  deleted?

With this message alone it’s difficult to investigate the problem
because it doesn’t include the calling user, the user for which the
change is not visible. Change it to

  Change <change-number>: Depends on change that was not submitted.
  Commit <sha1-commit-1> depends on commit <sha1-commit-2> which cannot
  be merged.  Is the change of this commit not visible to <calling-user>
  or was it deleted?

Dry-run submits are executed in the background and hence there is no
current user available. This doesn’t matter since for dry-run submits
the message is anyway ignored.

Change-Id: I8ff1ad7041c9632b3fdbfdba19d83c984a776a01
Signed-off-by: Edwin Kempin <ekempin@google.com>