Only specify parameters if non-empty Specifying empty string throws an error for certain actions such as Submit that don't take any params. Release-Notes: skip Bug: Google b/431939712 Change-Id: I70286a46abf94c6ddaee2f8615b608a2a86a075e
diff --git a/polygerrit-ui/app/elements/change/gr-flows/gr-create-flow.ts b/polygerrit-ui/app/elements/change/gr-flows/gr-create-flow.ts index 19c06c2..fb24a06 100644 --- a/polygerrit-ui/app/elements/change/gr-flows/gr-create-flow.ts +++ b/polygerrit-ui/app/elements/change/gr-flows/gr-create-flow.ts
@@ -299,7 +299,9 @@ const action: {name: string; parameters?: string[]} = { name: stage.action, }; - action.parameters = stage.parameterStr.split(' '); + if (stage.parameterStr.length > 0) { + action.parameters = stage.parameterStr.split(' '); + } return { condition: stage.condition, action,
diff --git a/polygerrit-ui/app/elements/change/gr-flows/gr-create-flow_test.ts b/polygerrit-ui/app/elements/change/gr-flows/gr-create-flow_test.ts index 3b5930a..16e1fdb 100644 --- a/polygerrit-ui/app/elements/change/gr-flows/gr-create-flow_test.ts +++ b/polygerrit-ui/app/elements/change/gr-flows/gr-create-flow_test.ts
@@ -151,7 +151,7 @@ { condition: 'https://gerrit-review.googlesource.com/c/plugins/code-owners/+/441321 is single condition', - action: {name: 'single action', parameters: ['']}, + action: {name: 'single action'}, }, ]); }); @@ -243,12 +243,12 @@ { condition: 'https://gerrit-review.googlesource.com/c/plugins/code-owners/+/441321 is cond 1', - action: {name: 'act 1', parameters: ['']}, + action: {name: 'act 1'}, }, { condition: 'https://gerrit-review.googlesource.com/c/plugins/code-owners/+/441321 is cond 2', - action: {name: 'act 2', parameters: ['']}, + action: {name: 'act 2'}, }, ]); }); @@ -295,12 +295,12 @@ { condition: 'https://gerrit-review.googlesource.com/c/plugins/code-owners/+/441321 is cond 1', - action: {name: 'act 1', parameters: ['']}, + action: {name: 'act 1'}, }, { condition: 'https://gerrit-review.googlesource.com/c/plugins/code-owners/+/441321 is cond 2', - action: {name: 'act 2', parameters: ['']}, + action: {name: 'act 2'}, }, ]); });