tree b24b24ec7d1775fbc93f99ab15e21ea4804a2bd9
parent bc425ff53b99c22601c60e511432f53a748e8d99
author Dave Borowitz <dborowitz@google.com> 1471532075 -0400
committer Dave Borowitz <dborowitz@google.com> 1471532587 -0400

Refuse to rebuild changes with no patch sets

The implementation of NoteDb requires every commit in the meta graph
to have a patch set ID. The implementation of ChangeRebuildImpl was
unintentionally setting the patch set to the current patch set of the
change, even if there were no actual PatchSet entities in ReviewDb to
back that up. Also unintentionally, parsing this result back would
succeed, and even produce the correct Change fields to make
ChangeBundle's diff happy.

Changes in this state are really corrupt, though, and can't be shown
in the UI, among other things. We should just ignore them when
converting to NoteDb, which is equivalent to obliterating them.

Change-Id: I376d89770fb3b3870e7111e5170882a14419e0a2