tree 121413937f68b7d9555d27353c02d6c03284b0dc
parent f22c5b2f816f5fc052ff722622859e6e204b886e
author Ben Rohlfs <brohlfs@google.com> 1674733521 +0100
committer Ben Rohlfs <brohlfs@google.com> 1674749389 +0100

Refactor gr-router_test

The new test is 400 lines shorter, but simpler and produces more test
coverage. It actually tests the pattern matching, which did not happen
before.

We are now consistently using these 3 methods:
* checkRedirect
* checkRedirectToLogin
* checkUrlToState

The names of the test are named directly after their `RoutePattern`.
And most of the time we also copy the pattern as a comment into the
test, so the tests are super easy to read and understand what they
are supposed to be testing.

We are only doing all this, so that we can follow-up with other
refactorings. We need decent test coverage, so that we can be sure
to not break anything.

Also, moving routes into view model files will be much easier now,
because in this new format the tests will be super easy to copy.

Release-Notes: skip
Change-Id: Ib3dc0362099ed56948bce0b7d382d3e8cd184681